[quagga-dev,15450,1/3] pimd: Remove dead code.

Message ID 1464848429-10245-1-git-send-email-sharpd@cumulusnetworks.com
State Under Review
Headers show
Series
  • [quagga-dev,15450,1/3] pimd: Remove dead code.
Related show

Commit Message

Donald Sharp June 2, 2016, 6:20 a.m.
No need to keep '#if 0' code.  If we need it in the future,
just go back into the history and grab it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---
 pimd/pim_zebra.c | 17 -----------------
 1 file changed, 17 deletions(-)

Comments

Jafar Al-Gharaibeh June 7, 2016, 2:41 p.m. | #1
Acked-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

On 6/2/2016 1:20 AM, Donald Sharp wrote:
> No need to keep '#if 0' code.  If we need it in the future,
> just go back into the history and grab it.
>
> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
> ---
>   pimd/pim_zebra.c | 17 -----------------
>   1 file changed, 17 deletions(-)
>
> diff --git a/pimd/pim_zebra.c b/pimd/pim_zebra.c
> index 8f85b17..4167a71 100644
> --- a/pimd/pim_zebra.c
> +++ b/pimd/pim_zebra.c
> @@ -51,23 +51,6 @@ static int del_oif(struct channel_oil *channel_oil,
>   		   struct interface *oif,
>   		   uint32_t proto_mask);
>   
> -#if 0
> -static void zclient_broken(struct zclient *zclient)
> -{
> -  struct listnode  *ifnode;
> -  struct interface *ifp;
> -
> -  zlog_warn("%s %s: broken zclient connection",
> -	    __FILE__, __PRETTY_FUNCTION__);
> -
> -  for (ALL_LIST_ELEMENTS_RO(iflist, ifnode, ifp)) {
> -    pim_if_addr_del_all(ifp);
> -  }
> -
> -  /* upon return, zclient will discard connected addresses */
> -}
> -#endif
> -
>   /* Router-id update message from zebra. */
>   static int pim_router_id_update_zebra(int command, struct zclient *zclient,
>   				      zebra_size_t length, vrf_id_t vrf_id)

Patch hide | download patch | download mbox

diff --git a/pimd/pim_zebra.c b/pimd/pim_zebra.c
index 8f85b17..4167a71 100644
--- a/pimd/pim_zebra.c
+++ b/pimd/pim_zebra.c
@@ -51,23 +51,6 @@  static int del_oif(struct channel_oil *channel_oil,
 		   struct interface *oif,
 		   uint32_t proto_mask);
 
-#if 0
-static void zclient_broken(struct zclient *zclient)
-{
-  struct listnode  *ifnode;
-  struct interface *ifp;
-
-  zlog_warn("%s %s: broken zclient connection",
-	    __FILE__, __PRETTY_FUNCTION__);
-
-  for (ALL_LIST_ELEMENTS_RO(iflist, ifnode, ifp)) {
-    pim_if_addr_del_all(ifp);
-  }
-
-  /* upon return, zclient will discard connected addresses */
-}
-#endif
-
 /* Router-id update message from zebra. */
 static int pim_router_id_update_zebra(int command, struct zclient *zclient,
 				      zebra_size_t length, vrf_id_t vrf_id)